fix(proxy): add L7 inspection to forward proxy path#666
Merged
johntmyers merged 3 commits intoNVIDIA:mainfrom Mar 30, 2026
Merged
fix(proxy): add L7 inspection to forward proxy path#666johntmyers merged 3 commits intoNVIDIA:mainfrom
johntmyers merged 3 commits intoNVIDIA:mainfrom
Conversation
Make evaluate_l7_request() public so the forward proxy path can evaluate individual requests against L7 policy without going through the full relay_with_inspection() loop. Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
The forward proxy previously rejected all requests to endpoints with L7 rules (blanket 403), forcing clients through the CONNECT tunnel. This meant policies like read-only (allow GET, block POST) had no effect on plain http:// requests through the forward proxy. Replace the blanket rejection with actual L7 evaluation: - Query L7 config for the endpoint (same as before) - Clone the OPA engine and evaluate the request method/path - Allow if L7 policy permits, deny with 403 if enforcement is enforce - Audit mode: log but allow (matching CONNECT path behavior) - Fail-closed: deny on evaluation errors The forward proxy uses Connection: close (one request per connection), so a single evaluation suffices — no relay loop needed. Update e2e tests to validate the new behavior: - GET /allowed → 200 (L7 policy allows) - POST /allowed → 403 (L7 policy denies, enforcement: enforce) Update security-policy.md to reflect the new forward proxy L7 behavior. Closes NVIDIA#643 Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
Collaborator
|
Thank you. None of your PRs are following the AGENTS.md guidance for pre-commits. While the PRs are welcomed please ensure to follow this guidance. |
Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
Contributor
Author
|
Understood — thanks for the feedback and info! I've now set up |
johntmyers
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The forward proxy previously rejected all requests to endpoints with L7 rules (blanket 403), forcing clients through the CONNECT tunnel. Policies like
access: read-only(allow GET, block POST) had no effect on plainhttp://requests via the forward proxy. This PR replaces the blanket rejection with actual L7 evaluation.Related Issue
Closes #643
Changes
evaluate_l7_request()public for cross-module use.enforcement: enforceand policy denies.architecture/security-policy.mdV1 simplifications note.Security posture change
Endpoints that previously received a blanket 403 on the forward proxy path will now be evaluated against their L7 policy. The forward proxy uses
Connection: close(one request per connection), so a single L7 evaluation suffices.Testing
mise run pre-commitpassesExecuted:
mise run pre-commitlocally: format, license, and lint checks passChecklist